nwjs / nw-gyp

native addon build tool for node-webkit
MIT License
195 stars 50 forks source link

nw-gyp cannot build netroute #43

Closed nickcmaynard closed 10 years ago

nickcmaynard commented 10 years ago

nw-gyp does not successfully build the netroute module.

nellie:netroute nick$ nw-gyp rebuild --target=0.10.3
gyp info it worked if it ends with ok
gyp info using nw-gyp@0.12.2
gyp info using node@0.10.30 | darwin | x64
gyp info spawn python
gyp info spawn args [ '/usr/local/lib/node_modules/nw-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/nick/Documents/Personal/kwango/rc/builder/app/node_modules/nat-upnp/node_modules/netroute/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/usr/local/lib/node_modules/nw-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/nick/.nw-gyp/0.10.3/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/Users/nick/.nw-gyp/0.10.3',
gyp info spawn args   '-Dmodule_root_dir=/Users/nick/Documents/Personal/kwango/rc/builder/app/node_modules/nat-upnp/node_modules/netroute',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  CXX(target) Release/obj.target/netroute/src/netroute.o
../src/netroute.cc:31:36: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle<Value> GetInfo(const Arguments& args) {
                                   ^~~~~~~~~
                                   v8::internal::Arguments
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:149:7: note: 'v8::internal::Arguments' declared here
class Arguments;
      ^
../src/netroute.cc:32:15: error: calling a protected constructor of class 'v8::HandleScope'
  HandleScope scope;
              ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:845:13: note: declared protected here
  V8_INLINE HandleScope() {}
            ^
../src/netroute.cc:33:38: error: too few arguments to function call, single argument 'isolate' was not specified
  Local<Object> result = Object::New();
                         ~~~~~~~~~~~ ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:2461:3: note: 'New' declared here
  static Local<Object> New(Isolate* isolate);
  ^
../src/netroute.cc:35:11: error: no matching member function for call to 'Set'
  result->Set(ip4_sym, GetInfo(AF_INET));
  ~~~~~~~~^~~
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:2182:8: note: candidate function not viable: no known conversion from 'Persistent<v8::String>' to 'Handle<v8::Value>' for 1st argument
  bool Set(Handle<Value> key,
       ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:2186:8: note: candidate function not viable: no known conversion from 'Persistent<v8::String>' to 'uint32_t' (aka 'unsigned int') for 1st argument
  bool Set(uint32_t index, Handle<Value> value);
       ^
../src/netroute.cc:36:11: error: no matching member function for call to 'Set'
  result->Set(ip6_sym, GetInfo(AF_INET6));
  ~~~~~~~~^~~
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:2182:8: note: candidate function not viable: no known conversion from 'Persistent<v8::String>' to 'Handle<v8::Value>' for 1st argument
  bool Set(Handle<Value> key,
       ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:2186:8: note: candidate function not viable: no known conversion from 'Persistent<v8::String>' to 'uint32_t' (aka 'unsigned int') for 1st argument
  bool Set(uint32_t index, Handle<Value> value);
       ^
../src/netroute.cc:38:16: error: no member named 'Close' in 'v8::HandleScope'
  return scope.Close(result);
         ~~~~~ ^
../src/netroute.cc:43:15: error: calling a protected constructor of class 'v8::HandleScope'
  HandleScope scope;
              ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:845:13: note: declared protected here
  V8_INLINE HandleScope() {}
            ^
../src/netroute.cc:45:33: error: 'New' is a private member of 'v8::PersistentBase<v8::String>'
  ip4_sym = Persistent<String>::New(String::NewSymbol("IPv4"));
                                ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:594:23: note: declared private here
  V8_INLINE static T* New(Isolate* isolate, T* that);
                      ^
../src/netroute.cc:45:45: error: no member named 'NewSymbol' in 'v8::String'
  ip4_sym = Persistent<String>::New(String::NewSymbol("IPv4"));
                                    ~~~~~~~~^
../src/netroute.cc:46:33: error: 'New' is a private member of 'v8::PersistentBase<v8::String>'
  ip6_sym = Persistent<String>::New(String::NewSymbol("IPv6"));
                                ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:594:23: note: declared private here
  V8_INLINE static T* New(Isolate* isolate, T* that);
                      ^
../src/netroute.cc:46:45: error: no member named 'NewSymbol' in 'v8::String'
  ip6_sym = Persistent<String>::New(String::NewSymbol("IPv6"));
                                    ~~~~~~~~^
../src/netroute.cc:47:34: error: 'New' is a private member of 'v8::PersistentBase<v8::String>'
  dest_sym = Persistent<String>::New(String::NewSymbol("destination"));
                                 ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:594:23: note: declared private here
  V8_INLINE static T* New(Isolate* isolate, T* that);
                      ^
../src/netroute.cc:47:46: error: no member named 'NewSymbol' in 'v8::String'
  dest_sym = Persistent<String>::New(String::NewSymbol("destination"));
                                     ~~~~~~~~^
../src/netroute.cc:48:37: error: 'New' is a private member of 'v8::PersistentBase<v8::String>'
  gateway_sym = Persistent<String>::New(String::NewSymbol("gateway"));
                                    ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:594:23: note: declared private here
  V8_INLINE static T* New(Isolate* isolate, T* that);
                      ^
../src/netroute.cc:48:49: error: no member named 'NewSymbol' in 'v8::String'
  gateway_sym = Persistent<String>::New(String::NewSymbol("gateway"));
                                        ~~~~~~~~^
../src/netroute.cc:49:37: error: 'New' is a private member of 'v8::PersistentBase<v8::String>'
  netmask_sym = Persistent<String>::New(String::NewSymbol("netmask"));
                                    ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:594:23: note: declared private here
  V8_INLINE static T* New(Isolate* isolate, T* that);
                      ^
../src/netroute.cc:49:49: error: no member named 'NewSymbol' in 'v8::String'
  netmask_sym = Persistent<String>::New(String::NewSymbol("netmask"));
                                        ~~~~~~~~^
../src/netroute.cc:50:37: error: 'New' is a private member of 'v8::PersistentBase<v8::String>'
  genmask_sym = Persistent<String>::New(String::NewSymbol("genmask"));
                                    ^
/Users/nick/.nw-gyp/0.10.3/deps/v8/include/v8.h:594:23: note: declared private here
  V8_INLINE static T* New(Isolate* isolate, T* that);
                      ^
../src/netroute.cc:50:49: error: no member named 'NewSymbol' in 'v8::String'
  genmask_sym = Persistent<String>::New(String::NewSymbol("genmask"));
                                        ~~~~~~~~^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [Release/obj.target/netroute/src/netroute.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/nw-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:810:12)
gyp ERR! System Darwin 13.3.0
gyp ERR! command "node" "/usr/local/bin/nw-gyp" "rebuild" "--target=0.10.3"
gyp ERR! cwd /Users/nick/Documents/Personal/kwango/rc/builder/app/node_modules/nat-upnp/node_modules/netroute
gyp ERR! node -v v0.10.30
gyp ERR! nw-gyp -v v0.12.2
gyp ERR! not ok 
nickcmaynard commented 10 years ago

Fixed by https://github.com/indutny/node-netroute/commit/6432facdb2da794d8028b2225ea948a01a4ba523