search

nwjs / nw-gyp

native addon build tool for node-webkit
MIT License
195 stars 46 forks source link

NW-GYP not recognising Visual Studio 2015 as a valid build tool on Windows 10 #80

Closed jpcharlesworth closed 7 years ago

jpcharlesworth commented 8 years ago

I have been investigating at some length why I cannot build sqlite 3 for Node-Webkit on Windows 10.

I have installed Visual Studio Community Version with C++ but nw-gyp does not recognise GYP_MSVS_VERSION=2015 as referring to a valid version; see attached file MSVSVersionError.txt. MSVSVersionError.txt

I looked in the code on the nw-gyp repository and it appears that there have been no commits for 2 years, so clearly no changes have been made to accommodate VS2015. MSVSVersionError.txt

konistehrad commented 8 years ago

:+1: for this. Building against 0.13 betas requires MSVS 2015 compliments V8, but at present nw-gyp doesn't support it. Seeing the same errors.

csiqueirasilva commented 8 years ago

There is a pull request that fix this for non-enterprise editions. I use the 2015 Enterprise Edition and had to add another value in the versions object (in this file).

'2015e': VisualStudioVersion('2015', 'Visual Studio 2015', solution_version='12.00', project_version='14.0', flat_sln=False, uses_vcxproj=True, path=path, sdk_based=sdk_based, default_toolset='v140'),

Also added this in the version_map:

'2015e': ('14.0',),

ghostoy commented 7 years ago

It should be fixed by our latest release of nw-gyp.