search

nwjs / nw.js

Call all Node.js modules directly from DOM/WebWorker and enable a new way of writing applications with all Web technologies.
https://nwjs.io
MIT License
40.39k stars 3.88k forks source link

Windows: Shows blue frame temporarily when clicking blurred app #2784

Closed adam-lynch closed 6 years ago

adam-lynch commented 9 years ago

  1. Unfocused app:

    unfocused

    That top bar is draggable.

  2. If I click the draggable area, I see the following:

    blue frame

    The top left contains the app icon & name.

If I click and hold, the effect is shown continuously up for up to 2 seconds and then disappears, even if I still have my mouse down on the draggable area.

If I click and drag the app, it's not shown as long as it would if I clicked and held down the mouse (without moving it). In this case it's shown about as long as it would if I just made a simple click on the draggable area.

node-webkit: 0.11.2. Windows: 8.1 64-bit.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

adam-lynch commented 9 years ago

I have seen this frame before with earlier versions of node-webkit, only when a window was becoming unresponsive, etc.

adam-lynch commented 9 years ago

Correction: This can happen when clicking anywhere on the app.

To be clear, if I click and hold or click and try to drag on a non-draggable area of the blurred app, the blue frame is only shown for a short period of time (as if I just clicked), so draggable areas seem to exaggerate this problem.

adam-lynch commented 9 years ago

Oh and I'm using transparency; my <body> has background: transparent. I wonder could this be related, @jtg-gg?

jtg-gg commented 9 years ago

@adam-lynch what setting you use in package.json ? is the "frame" : true if yes, then it is normal to see the "blue" frame. I can't give it black color, windows does not give me API to do that

adam-lynch commented 9 years ago

@jtg-gg no, the window is frameless.

if yes, then it is normal to see the "blue" frame

I think you could be wrong though. If I sent the frame to true, then the frame is the same color of the rest of my windows; which is gray when blurred and pinkish (which Windows grabs from my wallpaper) when focused right now.

Just like HipChat's frame here:

image

I don't know if you can tell from my screenshots in the first comment, that's not a normal frame even if I had the frame turned on; the only button shown is a close button and the frame is on top of my app not above it. Have a look at my first screenshot again, I've a blackish horizontal bar then below that the app is split into a blackish and white section. But in the screenshot with this weird blue frame, you can't see the top bar because this frame is over it. You can see that in that second screenshot because you can no longer see my custom minimize, maximize and close buttons in the right corner.

Also, even if I had frame to true, it would be shown 100% of the time, not just appearing when the unfocused app is clicked.

I hope it's clearer now what's happening. If it's not, let me know.

adam-lynch commented 9 years ago

See https://www.youtube.com/watch?v=UBaMRV3E8gw&feature=youtu.be.

I also noticed when making this that sometimes the blue frame flashes in when clicking away from the the focused app, but not all of the time.

adam-lynch commented 9 years ago

@jtg-gg sorry, you were right about the blue-ness of the frame. I was thinking of the frame I'd get if I didn't have transparency set to true. So what's happening here is that for a frameless app, when the app is not focused and I click on it, the frame is appearing briefly (over the content, not around it) and sometimes briefly appears when clicking away (blurring) the app.

jtg-gg commented 9 years ago

@adam-lynch I encounter this problem before with my laptop (intel GPU), are you using one ? what is your computer GPU ?

jtg-gg commented 9 years ago

@adam-lynch I have the fix, waiting @rogerwang to merge it https://github.com/rogerwang/node-webkit/pull/2859

adam-lynch commented 9 years ago

Great

On Wed, 24 Dec 2014 04:23 jtg-gg notifications@github.com wrote:

@adam-lynch https://github.com/adam-lynch I've the fix, waiting @rogerwang https://github.com/rogerwang to merge it

2859 https://github.com/rogerwang/node-webkit/pull/2859

— Reply to this email directly or view it on GitHub https://github.com/rogerwang/node-webkit/issues/2784#issuecomment-68024994 .

ghost commented 9 years ago

Hi adam really I don't know that is big? Wow you create chromeless window right? Thanks for truth. I will test. But I am using 0.12.3 and it hasn't bug right?

Best regards Jens Eckervogt ( aka username SourceSkyBoxer )

adam-lynch commented 9 years ago

@sourceskyboxer I think this has been fixed in later versions. I'm using 0.12.2 and it's fine. @jtg-gg this is ok to close right?

ghost commented 9 years ago

I understand. Thanks.

stale[bot] commented 7 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.