nwjs / nw.js

Call all Node.js modules directly from DOM/WebWorker and enable a new way of writing applications with all Web technologies.
https://nwjs.io
MIT License
40.32k stars 3.89k forks source link

Debug symbols for Windows is missing since version 0.59.0 #7892

Open YLivay opened 2 years ago

YLivay commented 2 years ago

Hello,

I'm trying to download the debug symbols for Windows on version 0.62.2 but noticed the symbol files are empty. After a quick scan of https://dl.nwjs.io, seems like the last version that had symbols for Windows is 0.58.0.

Nothing changed in BUILD.gn that would have affected this, so I'm guessing tools/dump_syms.exe just stopped working on the newer versions for some reason?

There are some commits in chromium around that time frame that seem related, but im way out of my depth here ;) https://chromium.googlesource.com/breakpad/breakpad/+log/refs/heads/main/src/tools/windows

Hopefully this is an easy fix!

YLivay commented 2 years ago

Bump!

Is there anything I can help with?

YLivay commented 2 years ago

@rogerwang Hey, im still stuck with this. im willing to give this a stab myself and contribute back but i dont know even where to begin with.

ayushmanchhabra commented 9 months ago
ninja -C outst/nw dump
ninja: Entering directory `outst/nw'
[1/20] ACTION //chrome/test/chromedriver/constants:version_header_action(//build/toolchain/win:win_clang_x64)
[2/20] STAMP obj/chrome/test/chromedriver/constants/version_header_action.stamp
[3/20] ACTION //chrome/test/chromedriver:embed_mobile_devices_in_cpp(//build/toolchain/win:win_clang_x64)
[4/20] STAMP obj/chrome/test/chromedriver/embed_mobile_devices_in_cpp.stamp
[5/20] CXX obj/chrome/test/chromedriver/constants/version_header/version.obj
[6/20] STAMP obj/chrome/test/chromedriver/automation_client_lib.inputdeps.stamp
[7/20] STAMP obj/chrome/test/chromedriver/lib.inputdeps.stamp
[8/20] STAMP obj/chrome/test/chromedriver/constants/version_header.stamp
[9/20] CXX obj/chrome/test/chromedriver/automation_client_lib/mobile_device_list.obj
[10/20] CXX obj/chrome/test/chromedriver/automation_client_lib/mobile_device.obj
[11/20] CXX obj/chrome/test/chromedriver/lib/chrome_launcher.obj
[12/20] CXX obj/chrome/test/chromedriver/automation_client_lib/url_request_context_getter.obj
[13/20] STAMP obj/chrome/test/chromedriver/automation_client_lib.stamp
[14/20] CXX obj/chrome/test/chromedriver/lib/http_handler.obj
[15/20] STAMP obj/chrome/test/chromedriver/lib.stamp
[16/20] CXX obj/v8/nwjc/nwjc.obj
[17/20] LINK chromedriver.exe chromedriver.exe.pdb
[18/20] LINK nwjc.exe nwjc.exe.pdb
[19/20] ACTION //content/nw:dump(//build/toolchain/win:win_clang_x64)
CoCreateInstance CLSID_DiaSource {3BFCEA48-620F-4B6B-81F7-B9AF75454C7D} failed (msdia*.dll unregistered?)
Open failed
CoCreateInstance CLSID_DiaSource {3BFCEA48-620F-4B6B-81F7-B9AF75454C7D} failed (msdia*.dll unregistered?)
Open failed
CoCreateInstance CLSID_DiaSource {3BFCEA48-620F-4B6B-81F7-B9AF75454C7D} failed (msdia*.dll unregistered?)
Open failed

7-Zip (a) 22.01 (x64) : Copyright (c) 1999-2022 Igor Pavlov : 2022-07-15

Open archive: nw.sym.7z
--
Path = nw.sym.7z
Type = 7z
Physical Size = 153
Headers Size = 153
Solid = -
Blocks = 0

Scanning the drive:
3 files, 0 bytes

Updating archive: nw.sym.7z

Add new data to archive: 3 files, 0 bytes

Files read from disk: 0

Archive size: 153 bytes (1 KiB)

Everything is Ok

[20/20] STAMP obj/content/nw/dump.stamp
program finished with exit code 0
elapsedTime=41.232000

https://forum.sentry.io/t/dump-syms-does-not-work-on-windows-with-pdb-files/4310 After going through the debug log, this^ might be the issue.

sirisian commented 5 months ago

How do I get the symbols? Is there a simple method others are using? I have a crash I'm looking at in 0.87.0 in Windows on 64-bit and I was trying to follow:

https://docs.nwjs.io/en/latest/For%20Developers/Understanding%20Crash%20Dump/#find-minidump-file

It's still referencing the downloads that are 0 bytes.

@rogerwang Is there a workaround for this to get the symbols or another method to get them?