Enable building Node native addon via Python 3

nwjs / nw.js

Call all Node.js modules directly from DOM/WebWorker and enable a new way of writing applications with all Web technologies.

https://nwjs.io

MIT License

40.16k stars 3.88k forks source link

Enable building Node native addon via Python 3 #8145

Closed ayushmanchhabra closed 5 months ago

ayushmanchhabra commented 6 months ago

Description

Depends on https://github.com/nwjs/node/pull/58.

This is a follow up of https://github.com/nwjs/nw.js/pull/8134 which turned out to be an incorrect fix. This PR will allow nw-builder to build node native addons (directly via node-gyp using NW.js node headers) using Python 3. Since only ICU requires v8_host_byteorder, I have moved it there. After making these changes, I am able to successfully build Node. I'm planning to submit a test case for this in a subsequent PR.

ayushmanchhabra commented 6 months ago

Can we get this merged in for upcoming v0.83?

rogerwang commented 6 months ago

Can we get this merged in for upcoming v0.83?

yes I will try to.