search

nwjs / nw.js

Call all Node.js modules directly from DOM/WebWorker and enable a new way of writing applications with all Web technologies.
https://nwjs.io
MIT License
40.16k stars 3.88k forks source link

"Stop Sharing" button is missing #8156

Open shikhak opened 4 months ago

shikhak commented 4 months ago

Issue Type

Before opening an issue, please search and see if it has already been raised.

Current/Missing Behavior

"Stop sharing " button is missing while sharing screen via webrtc site.

Expected/Proposed Behavior

"Stop sharing" button should be visible and user should be able to stop the screen sharing.

Additional Info

sysrage commented 4 months ago

I have also reproduced this in Windows 10.

shikhak commented 4 months ago

@ayushmanchhabra Shared this patch with me https://github.com/nwutils/nw-patches/blob/43b75a657fd877594d548a281cd02bc486a897d3/patches/chromium.patch#L8129-8206

By un-doing the following changes Stop sharing button is visible and working as expected:

X_is_sharing_your_screen

File 1 : Undo all the changes in file : nw/chromium/chrome/browser/media/webrtc/desktop_capture_devices_util.cc

File 2: nw/chromium/chrome/browser/media/webrtc/desktop_capture_access_handler.cc

Only remove this change "extension->is_nwjs_app() ||" at two places (line no : 8098, 8106)

sysrage commented 4 months ago

@rogerwang please take a look and revert these changes unless they're needed for some reason.

shikhak commented 4 months ago

PR : https://github.com/nwjs/chromium.src/pull/165/files