search

nwjs / nw.js

Call all Node.js modules directly from DOM/WebWorker and enable a new way of writing applications with all Web technologies.
https://nwjs.io
MIT License
40.35k stars 3.89k forks source link

nwjs truncating chrome args from package.json on windows #8219

Open zkrige opened 1 month ago

zkrige commented 1 month ago

Issue Type

Before opening an issue, please search and see if it has already been raised.

from package.json "chromium-args": "--enable-gcm --disable-features=ProcessPerSiteUpToMainFrameThreshold --user-agent='' --enable-features=NativeNotifications --enable-chrome-browser-cloud-management --enable-speech-dispatcher --enable-logging --js-flags='--no-flush-bytecode' --disable-web-security --allow-file-access --allow-file-access-from-files --enable-experimental-web-platform-features ",

from chrome://flags \nwjs-sdk-v0.91.0-win-x64\nw.exe" --remote-debugging-port=9222 --enable-gcm --disable-features=ProcessPerSiteUpToMainFrameThreshold --user-agent --enable-features=NativeNotifications --enable-chrome-browser-cloud-management --enable-speech-dispatcher --enable-logging --js-flags=--no-flush-bytecode --disable-web-sec�I"

this is what was causing https://github.com/nwjs/nw.js/issues/8218 - I had enable-gcm at the end and it was being truncated and not sent to chrome

so a couple of my chrome flags arent actually being sent to chrome - this appears to happen only on windows

ayushmanchhabra commented 1 month ago

Most likely related to #7670. Although I noticed that the character count in your repro is 284 - not sure what's going on there 👀

zkrige commented 1 month ago

Remote debugging port isn't part of the package.json - it's a node command line parameter

The 260 limit seems to be on args set in package.JSON

@rogerwang this is currently affecting over 500 000 devices running our app

We urgently need a fix here

zkrige commented 1 month ago

closing because duplicate of #7670

zkrige commented 2 weeks ago

Reopening this for visibility