On Windows 10 taskbar icon points to non-existent "chrome_proxy.exe" instead of "nw.exe".

LostBeard commented 1 month ago

Issue Type

[X] Bug Report
[X] Successfully reproduced against the latest version of NW.js

Expected/Proposed Behavior

I expected the taskbar icon to point to the nw.exe app.

Additional Info

Operating System: Windows 10 x64
NW.js Version: 0.92.0 sdk

To reproduce

On a Windows 10 x64 PC (32bit has same issue)

Download and extract nwjs-sdk-v0.92.0-win-x64.zip
Run nw.exe (same result with and without a manifest)
Right click the NWJS taskbar icon
Right click the option: "NWJS Default"
Click "Properties"
The properties window will show that the icon Target is "...\chrome_proxy.exe" and not "...\nw.exe" as it should be.

This issue prevents the use of the "Pin to taskbar" option because the pinned icon will try to launch "chrome_proxy.exe" which does not exist.

This bug has been reported before as issue #7033. It was fixed and closed. This seems to be a regression due to changes since that fix.

The file that was modified to fix this issue before (#7033) was chrome/browser/web_applications/components/web_app_shortcut_win.cc. I wanted to look at that file to see what had changed and it seems it no longer exists. The folder chrome/browser/web_applications/components no longer exists (web_applications).

NWjsPinnedTaskbarIconIssue

LostBeard commented 1 month ago

web_app_shortcut_win.cc has moved from components to the os_integration folder.

Located here: chrome/browser/web_applications/os_integration/web_app_shortcut_win.cc

ayushmanchhabra commented 1 month ago

@rogerwang PR is ready for review

ayushmanchhabra commented 2 weeks ago

https://github.com/nwjs/chromium.src/pull/166 @rogerwang I have shared the PR URL for visibility, requesting your review. Thanks

LostBeard commented 1 week ago

Looking forward to this bug getting fixed. Is there an issue with the PR holding this up?

nwjs / nw.js