search

nwn2fixes / player

Fixes for the casual NwN2 player
29 stars 11 forks source link

Update credits.txt #2

Closed AxeEdge closed 6 years ago

AxeEdge commented 6 years ago

Adding a grammatical fix to Khelgar's dialog when he finds his clan's heirloom. A simple practice for when I go after a couple other dialogs I've found in the OC and MoW, which have actual problems

AxeEdge commented 6 years ago

13_heirloom.zip

Unzip and place 13_heirloom.DLG in: player-master/OC/1300_Old_Owl_Well

kevL commented 6 years ago

hi Axe, i'm curious... since this is a grammatical fix, and grammar is contained in Dialog.Tlk (for multi-lingual support) what did you do to the .Dlg file?

I ran a diff on it, but dialogs are binary and it didn't diff well. Am hoping you didn't replace a Dialog.Tlk reference with a literal string ... 'cause that's outside the purview of nwn2fixes (breaks multi-lingual support).

kevL commented 6 years ago

ok this time i looked at credits.txt -- making a change from "placed" to "place" would (i think) replace the Dialog.Tlk ref with a literal string ....

can i close this, 'cause there's not much we can do short of updating Dialog.Tlk

(if/as you find mechanical fixes those are welcome)

AxeEdge commented 6 years ago

Howdy!

I didn't touch the Dialog.Tlk, only edited the DLG file. If you open the DLG, search for AxeEdge (or just Axe) and you'll find my notation on the line changed.

With the file in my "override", Khelgar correctly says "place". After removing the file, he incorrectly says "placed". Putting the file back in Khelgar becomes his snooty proper Dwarf and says "place"

This is all without touching the Dialog.Tlk.

Poor Grausch, he gave up many lives over the past two days....

Anyway, correcting some grammatical errors is cool.

There are a couple conversations I'll look into. The First is when Grobnar is first met (area 1003, skymirror module), which is a simple pet peeve of mine. Going down a certain dialog tree, the PC says (essentially), "Well since you want to come with us, come on!". No where along the dialog tree does Grobnar indicate where he is going nor that he wants to go with the PC.

The second is actually a slight problem, within MoW. I'll have to look at the details on that one, again, for specifics.

AxeEdge commented 6 years ago

If editing the DLG file would change that line permanently to the new English version of that specific line in the conversation, for all languages, then, I'd say forget it. I'll just put it in my own override fixin' folder.

Edit: Yeah, just close this out. I found the line in the tlk file. Every time I dig into the toolset I learn lots, then, I step away for a long time and forget most.

:)

kevL commented 6 years ago

ok Axe, & here's my reply previous to your last edit:

If what you are saying is an edit in the DLG would change that line permanently to the new English version of that line, for all languages

yes, i'm pretty sure that changing a line in a dialog breaks the ref to Dialog.Tlk (so players playing in Italian, eg. would awkwardly see a line of English in an otherwise strictly Italian conversation). I've sent a message to kamal asking to confirm that, though

Here's what you can do in your own setup (ie, what i do). Backup, then edit your Dialog.Tlk itself.

TlkEdit2 does a pretty good job (it's never mis-saved on my end). There's a filter-box on the top, that's case sensitive(!). Note on Dialog.Tlk - the modified .Tlk can go in the root of your player folder, but to see changes in the toolset it has to go in the installation folder.

note2: Kaedrin's PrC Pack uses its own Dialog.Tlk (that needs to be edited if you're using the PrC Pack), etc