search

nwn2fixes / player

Fixes for the casual NwN2 player
27 stars 11 forks source link

MotB: Rest impossible with package installed #40

Open Scrapulous opened 4 years ago

Scrapulous commented 4 years ago

Clicking "Rest" just closes the rest window without any effect.

kevL commented 4 years ago

I can't replicate it. I loaded an old MotB save with a clean installation folder and an override folder with only Nwn2Fixes in it. No custom guis etc etc.

rest went fine here ...

i'll ask on the forum thread to see if anyone else has an issue with MotB resting

kevL commented 4 years ago

https://forum.neverwintervault.org/t/nwn2fixes/595/368?u=kevl_s

jigsaw717 commented 4 years ago

I just started MOTB and im having this issue. After about 30 minutes moving files back and forth, i've narrowed it down to 4 files causing the issue. In the base>script folder, its gui_rest.ncs and gui_rest.NSS and in the base>script>inc folder, its x2_inc_restsys.nss and ginc_restsys.NSS

kevL commented 4 years ago

so it's still there huh?

It seems like half the people using nwn2fixes get the problem and the other half don't ...

will take a look at those files, and probly take them out,

kevL commented 4 years ago

@jigsaw717 Are you using the latest fixes?

2020_mar_10.ver

jigsaw717 commented 4 years ago

i am indeed

kevL commented 4 years ago

ok. Am going to try a different approach ...

the underlying bug is that, in SoZ on the overlandmap, the player can choose a dialog option to Intimidate an encounter before going into battle but EffectShaken() and EffectOffGuard() use negative values when constructing the effects. Positive values should be used in 'ginc_overland' instead (the constructors for the effects will subtract the positive values).

Tracing those functions back through several layers, they could be called by 'gui_rest'. HOWEVER the only place i know of them being used is on the SoZ OL. And those are handled by just two scripts: 'ga_initiate_encounter' and 'ga_mated_encounter'.

So basically i'm going to delete gui_rest.ncs and gui_rest.NSS and x2_inc_restsys.nss and ginc_restsys.NSS. But keep 'ginc_overland' with the core fix, as well as 'ga_initiate_encounter' and 'ga_mated_encounter'.

and see how that plays,

jigsaw717 commented 4 years ago

I've got no idea what any of that means but i hope it works out well :D

kevL commented 4 years ago

we'll see :)

https://github.com/nwn2fixes/player/commit/f8424f94f70ef35d524fa1e1b6b2feee20ab94b5

The notes are just to get me straight on what's happening, and for anyone who reads it and wants to poke away at it themselves