nwn2fixes / player

Fixes for the casual NwN2 player
33 stars 11 forks source link

Jagged Tooth spell has no effect #41

Open SCREAMING-KEBAB opened 4 years ago

SCREAMING-KEBAB commented 4 years ago

Hi, I'm an old school PnP player with no developing skills. I happened to find this project during my latest nwn2 playthrough. I'm not sure what kind of bugs are supposed to be reported here (or if are to be reported at all) but I'll give it a go in good faith:

Jagged tooth effect doesn't show up in the animal statistics once cast. Furthermore, the description says it's cleric3/druid2 while in game works as a druid3/ranger2 spell.

kevL commented 4 years ago

good report.

first the description: This is an issue in Dialog.Tlk -- that is, all the localized strings that appear (in your language) as you play. However it's policy for Nwn2Fixes not to edit or re-issue the Dialog.Tlk file ...

You can however edit the Dialog.Tlk file on your end w/ the TlkEdit2 tool. Backup your original (in the Nwn2 installation folder) and look for entry #184637 <- the description for Jagged Tooth. If you're wondering where i get this data, it's from Spells.2da, row #1002 Jagged Tooth

and yep I can confirm a mismatch between the description in Dialog.Tlk and the spell levels given in Spells.2da.

The other issue is more difficult to deal with. It's not actually a bug per se. Keen (increased critical threat) is applied as an itemproperty on a recipient's "creature weapons" (these are hidden equipment slots that all creatures have, but are usually empty unless we're dealing with an animal or beast of some generally non-humanoid sort). The problem is that buffs on weapons don't appear in the creature's stats. The buff is there ... or at least it should be ... and the combat engine should be using it okay, but since it's an itemproperty and not an effect it doesn't show up on the creature's stats page.

@Clangeddin

Can you use your wiles to check if Jagged Tooth is really working as advertised? I ask because, after looking over my own jaggedtooth spellscript of a couple years ago, I see that i had to jump through a bunch of hoops to get it to actually work ... in short, i ended up applying Keen as a feat to a temporary item in inventory. (but I forget why, exactly -- not sure if it was because i wanted the stat-increase to show up on the stats page, or because combatdebugging was telling me that the stock Jagged Tooth spellscript simply doesn't work as is ...)

I'll send you my spellscript if you're interested.

Clangeddin commented 4 years ago

I've tested it and I can confirm the bug, jagged tooth simply does not work. I tried to fix it, but no avail, it appears to be hardcoded.

Edit: I'll try to see if the workaround you suggested might work.

kevL commented 4 years ago

my reworked jagged tooth spellscript https://pastebin.com/1dRXGg68

kevL commented 4 years ago

@Clangeddin

hm,

I have this note in my spellscript, re. the featholder item:

// - note: IPs on an inventory-active item have to be added before the item
//   enters the target's inventory. So create the item on the ground and copy
//   it into target's inventory.

that is, something seems to prevent an itemproperty from being added to an item in a creature's inventory (roughly speaking, i haven't investigated it exhaustively). So I wonder, i might try to unequip the creature-weapon (if found) and apply the IP, then re-equip it

/bleh

in either case, am working up a spellscript for Jagged Tooth that uses a routine that I'm 99.9% sure works,

am currently testing ...

kevL commented 4 years ago

@Clangeddin

care to mull this over?

nw_s0_jagtooth.7z https://drive.google.com/file/d/14y-awfazuNStglJSpWZ2N4ZXEIEGjMvO/view?usp=sharing

2 noticeable bugs:

kevL commented 4 years ago

cont'd on the forum https://forum.neverwintervault.org/t/nwn2fixes/595/342?u=kevl_s