search

nwn2fixes / player

Fixes for the casual NwN2 player
27 stars 11 forks source link

Creature scripts #46

Closed Clangeddin closed 4 years ago

Clangeddin commented 4 years ago

Code refactoring with performance improvement of default creatures scripts. This is mainly achieved by reducing the number of calls of OBJECT_SELF by defining it as a variable once. Spawn script has some additional refactoring about treasure generation. Please examine thoroughly before committing.

I also reorganized the folder and moved the nw_e0_default8 script there.

kevL commented 4 years ago

wait a second,

Isn't putting nw_c2_default* scripts in /override going to screw with modules that customize the ai-scripts but (rightly or wrongly, wrongly in my opinion) KEEP THE SAME FILENAMES for those scripts

?

Clangeddin commented 4 years ago

Yes, it would, but that is the reason why I installed my NWN2fixes in the installation folder instead of the mydocuments one. But that's ok if you wanna delete this, perhaps the potential gain is not even worth the risk, after all this is not even a real bugfix.

kevL commented 4 years ago

at this point i just wanna mull things over ... your installation folder idea is making more & more sense

edit : I sorta wish the Fixes had been designed that way from the start,

kevL commented 4 years ago

did some testing; install/override has higher priority than campaign or module ...

too risky. Obsidian eg placed an 'nw_c2_default4' script in the Campaign_x2 folder (this change, whether to the install or player override, would ofc overrule their script)

/sighshrug