search

nwnxee / unified

Binaries available under the Releases tab on Github
https://nwnxee.github.io/unified
GNU General Public License v3.0
131 stars 92 forks source link

Deprecate some Weapon Plugin functions? #1191

Open shadguy opened 3 years ago

shadguy commented 3 years ago

Patch 8193.9 added these features to the base game: "Weapons-related feats (Focus, Epic Focus, Spec, Epic Spec, Improved Crit, Overwhelming Crit, Devastating Crit, Weapon of Choice) can now be customized on a per-baseitem case.

Please refer to baseitems.2da for the new columns"

Reference: https://steamdb.info/patchnotes/4783443/

That appears to make these NWNX functions seem redundant in the Weapon plugin:

I don't know if those do more than a 2da edit to feat.2da in the current game, or if they tie into other features of the plugin in a different way than basegame (whatever the GreaterWeapon() stuff is.

Does it make sense to deprecate these? I'm just fresh off the boat from 1.69, so I may be asking dumb questions.

-Dave

gm-xanther commented 3 years ago

I'd like to offer a case for keeping these, even if they're not the recommended method - A 2da edit can't really be edited "on the fly" in the same way by scripts, while the nwnx function can.

mtijanic commented 3 years ago

I'd like to offer a case of offloading the devcrit and similar stuff out of Weapon into the Events plugin, then most people can just not load the weapon plugin at all, since the bulk of it is already covered by the game.

See #746

Mefi100 commented 3 years ago

It would be a great if we still could set a single WeaponFocusFeat for multiple weapons. That's not possible with 2DAs.

shadguy commented 3 years ago

It would be a great if we still could set a single WeaponFocusFeat for multiple weapons. That's not possible with 2DAs.

Why not? Can you not point different baseitem.2da lines at the same focus feat? Am I misunderstanding? ShadowM did this in his HC_Base mod so that, for example, giant Greatswords and axes could reuse the base game focus feats without adding clutter.

What am I missing?

-Dave

shadguy commented 3 years ago

I'd like to offer a case for keeping these, even if they're not the recommended method - A 2da edit can't really be edited "on the fly" in the same way by scripts, while the nwnx function can.

It sounds like you have a good use case to keep them around, but see clippy's proposal.

-Dave

Mefi100 commented 3 years ago

It would be a great if we still could set a single WeaponFocusFeat for multiple weapons. That's not possible with 2DAs.

Why not? Can you not point different baseitem.2da lines at the same focus feat? Am I misunderstanding? ShadowM did this in his HC_Base mod so that, for example, giant Greatswords and axes could reuse the base game focus feats without adding clutter.

What am I missing?

-Dave

Sorry for the confusion. What I REALLY mean is multiple feats for a single baseitem. Let me explain my (sample) use case:

Epic Swordsman prestige class on the first level recieves Weapon Focus in all kind of swords with a single feat: "Epic Swordsman Weapon Focus". This feat is available only for this prestige class. In this case, we keep all the vanilla Weapon Focus feats as it is.

Perhaps this can be moved to the Feats plugin: NWNX_Feat_SetFeatModifier(2150, NWNX_FEAT_MODIFIER_WEAPON_FOCUS_AB, BASE_ITEM_KATAR, 1);

shadguy commented 3 years ago

Sorry for the confusion. What I REALLY mean is multiple feats for a single baseitem. Let me explain my (sample) use case:

Epic Swordsman prestige class on the first level recieves Weapon Focus in all kind of swords with a single feat: "Epic Swordsman Weapon Focus". This feat is available only for this prestige class. In this case, we keep all the vanilla Weapon Focus feats as it is.

Perhaps this can be moved to the Feats plugin: NWNX_Feat_SetFeatModifier(2150, NWNX_FEAT_MODIFIER_WEAPON_FOCUS_AB, BASE_ITEM_KATAR, 1);

OK, thank you for clarifying. That almost sounds like a whole new feature request, possibly tangential to the discussion here. That's okay - I'm just trying to understand. Do you think that's a fair comment?

-Dave

Mefi100 commented 3 years ago

Perhaps this can be moved to the Feats plugin: NWNX_Feat_SetFeatModifier(2150, NWNX_FEAT_MODIFIER_WEAPON_FOCUS_AB, BASE_ITEM_KATAR, 1);

OK, thank you for clarifying. That almost sounds like a whole new feature request, possibly tangential to the discussion here. That's okay - I'm just trying to understand. Do you think that's a fair comment?

-Dave

Well, not exactly a feature request, just a suggestion how Weapons plugin might be refactored. I was thinking about:

  1. Merging Weapons into the Feats Plugin.
  2. Replace SetWeaponFocusFeat() and SetWeaponSpecializationFeat() with more flexible functions that allow setting a variable attack/damage bonus instead of fixed +1/+2.

That would make sense from my perspective, as NWNX Weapons user.