search

nwnxee / unified

Binaries available under the Releases tab on Github
https://nwnxee.github.io/unified
GNU General Public License v3.0
128 stars 91 forks source link

Adding new functions: NWNX_ON_PLACEABLE_OPEN_{OPEN|CLOSE}_{BEFORE|AFTER} #1691

Closed ReachPW closed 11 months ago

ReachPW commented 11 months ago

This adds new events for Placeables, when opening and closing inventory.

NWNX_ON_OBJECT_OPEN_BEFORE NWNX_ON_OBJECT_OPEN_AFTER NWNX_ON_OBJECT_CLOSE_BEFORE NWNX_ON_OBJECT_CLOSE_AFTER

ReachPW commented 11 months ago

Should I delete this PR and do a new "clean" PR with just the finalized changes?

ReachPW commented 11 months ago

Since those events only run for placeables I think it's better to name the events NWNX_ONPLACEABLE{OPEN|CLOSE}_ or NWNX_ON_PLACEABLEINVENTORY{OPEN|CLOSE}_

updated.

Also please fix whatever's going on with that SWIG postprocess.sh!

Sorry about that, but not sure what is going on here.

When I do a new pull of repo it looks fine.

cat Plugins/SWIG/SWIG_DotNET/postprocess.sh 
#!/bin/bash

#Cleanup macro comments left by SWIG.
for f in out/*.cs
do
  sed -i 's/\/\*@SWIG.*\*\///' "$f"
done

I tried a few things to remove it from PR entirely, but still showing as empty under Files.

It was "undeleted" in this change: https://github.com/ReachPW/unified/commit/88d6c18213fb6640ce24cd3646d3afe5107c4541

so should be same as before, but I still don't understand why it showing 'empty' in the PR.

I can delete this PR and do a fresh PR with just the finalized changes and excluding that postprocess.sh ? Otherwise not sure how to resolve/fix.