nwnxee / unified

Binaries available under the Releases tab on Github
https://nwnxee.github.io/unified
GNU General Public License v3.0
130 stars 92 forks source link

BUG: Crash when NWNX_CORE_SKIP=Y #70

Closed nwngracken closed 6 years ago

nwngracken commented 6 years ago

I'm consistently crashing when loading the DockerDemo module that comes inside the nwnxee/nwserver:8164 docker container (https://hub.docker.com/r/nwnxee/nwserver/). NWNX_Core.so is being preloaded, but it's being skipped with the NWNX_CORE_SKIP=Y environmental variable, which is set in the attached config.txt file that contains the environmental variables passed to docker (with --env-file).

This crash does not happen when NWNX_Core.so is not LD_PRELOAD'ed.

This crash does not happen if NWNX_Core.so is LD_PRELOAD'ed and NWNX_CORE_SKIP=N

I've attached nwserver-crash-1521259791.log.

mtijanic commented 6 years ago

I guess it should fail gracefully instead of crashing, but.. what's the use-case of skipping the core?

nwngracken commented 6 years ago

There isn't one necessarily. I did it while debugging another crash issue. I'd think using NWNX_CORE_SKIP=Y would be a good way to turn off NWNX without removing NWNX_Core.so from LD_PRELOAD.

mtijanic commented 6 years ago

Ack, good point, for some deployments removing the preload might be a hassle. Thanks.

Liareth commented 6 years ago

Fixed in 8164-1.