JVM: nwnx_jvm_token wrong?

nwnxee / unified

Binaries available under the Releases tab on Github

https://nwnxee.github.io/unified

GNU General Public License v3.0

131 stars 92 forks source link

JVM: nwnx_jvm_token wrong? #9

Closed Liareth closed 5 years ago

Liareth commented 6 years ago

I noticed that nwnx_jvm_token.nss:5 and nwnx_jvm_token.nss:6 push an argument for the Event function but then call the Token function. I don't fully understand what this function does nor do I have the knowledge or setup to test it, but this seems wrong to me. It looks like every time call_token is called, 2 more arguments get pushed onto the Event stack, and Token gets called with nothing. Can someone (@niv @zunath) who knows about JVM investigate when you get a chance?

zunath commented 6 years ago

I'm not sure about this one. Will have to yield to @niv ...

mtijanic commented 5 years ago

WNF. JVM is a goner.