search

nwoeanhinnogaehr / pvoc-rs

A phase vocoder written in Rust
GNU General Public License v3.0
30 stars 8 forks source link

Upgrade dependencies and fix compile errors. #1

Closed PieterPenninckx closed 4 years ago

PieterPenninckx commented 4 years ago

Upgrade dependencies and fix compile errors.

nwoeanhinnogaehr commented 4 years ago

Thanks! Ping me when this is ready to merge and I'll take a look :)

PieterPenninckx commented 4 years ago

I think this is ready. What's holding me back is that I currently have no test to check if it still works as expected. I tried to write a test that checks if the original input audio can be approximately reconstructed. This test would always fail because of the windowing. I'm not an expert in phase vocoders, so I would like to ask if there is anything else, apart from the windowing, that should be taken into account when writing tests?

PieterPenninckx commented 4 years ago

I did some manual tests and the "problems" I saw are either expected or unlikely to be related to my changes, so for me it is ready now.

Edit: both "problems" can be solved with padding, as illustrated in the tests branch of my fork.

nwoeanhinnogaehr commented 4 years ago

Great! Thanks so much :heart: