search

nwolverson / purescript-language-server

MIT License
184 stars 41 forks source link

Add shell.nix to the list of files for detecting projects #137

Closed ursi closed 3 years ago

ursi commented 3 years ago

purs-nix is now compatible with Nix stable, which uses a shell.nix file instead of flake.nix

nwolverson commented 3 years ago

shell.nix doesn't unfortunately indicate one is using purs-nix. I don't think it matters too much, as this is only a warning, but this will no longer warn on projects with a shell.nix at the root, and nested purescript projects. The warning was useful for me yesterday in such a case

ursi commented 3 years ago

hm, well if that's how you feel then you should probably undo the flake.nix change, cuz flake.nix is just the new way to do nix shells in the unstable version of nix. I have my own version of purescript-language-server with these patches that one can easily use with purs-nix already, so it's not a huge deal if you don't want include them here.

nwolverson commented 3 years ago

I'm not sure how I feel - ideally it would be nice to detect purs-nix but it doesn't look like one can do that just looking at the flake.nix/shell.nix - I guess I was hoping you have a bright idea :)

ursi commented 3 years ago

Unfortunately no bright ideas here, at least not yet. If you really wanna be careful about not getting false positives, the best solution I can currently think of is what I'm currently doing - maintain a fork that detects (flake|shell).nix files as project roots and expose it via purs-nix.

nwolverson commented 3 years ago

Going to merge for now, for consistency with the flake.nix and to avoid an incorrect warning; restoring the warning for the other case TBD.