search

nwolverson / purescript-language-server

MIT License
184 stars 41 forks source link

Bad fixes for typeclass UnknownName #138

Closed nwolverson closed 1 year ago

nwolverson commented 3 years ago

image

We assume that UnknownName source span is the name itself, but for typeclass instances the compiler span is wider. This leads to a weird suggestion.

Should contribute a tightened span for this case to the compiler

nwolverson commented 2 years ago

(I looked at this at some point and it wasn't trivial to get the right span, naturally)

nwolverson commented 1 year ago

This is now fixed with https://github.com/purescript/purescript/pull/4383