search

nwolverson / purescript-language-server

MIT License
184 stars 41 forks source link

Qualified module completion not triggering #144

Closed nwolverson closed 2 years ago

nwolverson commented 3 years ago

Qualified module completion, eg. with no module imported qualified as Number, completing Number.fromString

At some point there seems to have been a change introduced, I know not where, that means that suggestions don't trigger automatically after typing the . and continuing to type. I can't find an existing issue for this, so may as well track that with this issue.

Actually it's odd, in vscode currently if I type "Number.fromS", the suggestion is just "Number" (type from Prim) and then if I wait a short while, the qualified-module suggestions pop up. If I manually trigger completion at that point instead, the qualified-module suggestions also pop up, same with editing elsewhere and going back to continue typing fromString.

nwolverson commented 2 years ago

Seems this was related to whether the returned suggestions list was reported as incomplete, the check for this was erroneous, so an incomplete list is filtered by further typing, rather than being recomputed.