Closed wclr closed 2 years ago
I don't recall why the shell version was avoided, but this is why which
(or rather node-which) was called for execing purs
etc, that's not done for formatters at least partly because there was some slowness issue and it was called each time.
1s is crazy slow, yes via language server is going to introduce some delay, yes windows seems likely to be slower, but that's massive.
It is a known issue that the node's spawn is not consistent across OS. It gives an error in the output when running formatter command -
ENOENT
.On windows spawn should be run with additional
{ shell: true }
to work in this case. Though currentNode.ChildProcess
version doesn't support theshell
param forspawn
. -(Also, I noticed that using Purescript IDE formatter works visibly slower (~1 sec) than when using vscode configured formatter (formats almost immediately):