nwolverson / purescript-language-server

MIT License
185 stars 42 forks source link

Config: Empty formatter, no formatter #180

Closed andys8 closed 2 years ago

andys8 commented 2 years ago

Hey,

Before looking it up, my first try to disable an existing formatter was to set the field to "". Later I found out there is "none".

I would also interpret "" as NoFormatter, but it's up to you if you think that's a good idea or not :)

wclr commented 2 years ago

The default formatter should be tidy nowdays. I think, any illegal value should be interpreted as no-formatter.

andys8 commented 2 years ago

Sounds good to me. @nwolverson What do you think?

nwolverson commented 2 years ago

Yep I agree, interpret anything other than the specific formatter strings as NoFormatter, something like vscode which has a default can set it to tidy

andys8 commented 2 years ago

Is the PR content in it's recent state okay?

andys8 commented 2 years ago

Oops, wrong button 😅