search

nwolverson / purescript-language-server

MIT License
184 stars 41 forks source link

Some errors don't show up on rebuild #79

Open nwolverson opened 4 years ago

nwolverson commented 4 years ago

Assume this may be something to do with not having source span - seem module related

nwolverson commented 4 years ago

An example which surely can't be the one I ran across in the wild, because I am not a monster:

module Prim.Module2 where

z :: Int
z = 42

Build on save, no errors. Full build, a CannotDefinePrimModules error. This error comes with reasonable looking source position:

"filename":"src/Module1.purs","position":{"startLine":1,"startColumn":1,"endLine":1,"endColumn":26}
kritzcreek commented 4 years ago

I have a feeling this check happens somewhere outside the rebuildModule machinery the ide server uses. Probably somewhere in figuring out the dependency graph.

nwolverson commented 3 years ago

Now this one I legitimately did hit on rebuild: https://github.com/purescript/purescript/issues/3949