nwolverson / vscode-language-purescript

PureScript Language Support for Visual Studio Code
https://marketplace.visualstudio.com/items/nwolverson.language-purescript
Other
17 stars 12 forks source link

Integration with `purty` #10

Closed joneshf closed 3 years ago

joneshf commented 5 years ago

Howdy!

I maintain a source code formatter: purty. I'd like to add support for using it from VS Code. The goal here is that formatting PS code be dead simple (not many install steps, no extra binaries to download, etc.).

I'd like the burden on you to be as minimal as possible, so when the API of purty changes, I expect to update whatever's necessary to work here. Would it be easier if I maintained an extension and this extension depended on it somehow (I don't know enough about the VS Code ecosystem)? There is an extension specifically for purty, but its releases have some drift from purtys. I'd like to minimize that as much as possible.

What are your thoughts?

mvakula commented 5 years ago

If needed I can make a PR for purty support here.

P.S. I also updated and published vscode-purty extension to work with the latest purty release.

nwolverson commented 5 years ago

Certainly my feeling is that a separate extension doing code formatting is a good thing. I don't think this extension should depend on it, as it is just the bare minimum syntax highlighting etc.

I thought that there was a way to recommend extensions, but it only seems to be per workspace not as a weak dependency of an extension? Possibly could add a dependency to ide-purescript which is already kitchen sink

nwolverson commented 5 years ago

At a bare minimum if someone wants to PR the readmes of this and ide-purescript before I get around to it, please do

nwolverson commented 3 years ago

Code formatting via purty is now provided via the purescript-language-server (or the extension linked previously) so I don't think this issue is relevant any more.