nwoolls / MultiMiner

Graphical application for crypto-coin mining
multiminerapp.com
MIT License
938 stars 368 forks source link

Crash with Network Devices with broken RPC API #164

Closed ManeBjorn closed 10 years ago

ManeBjorn commented 10 years ago

Since the newest update this error is back and in full force. See the end of this message for details on invoking just-in-time (JIT) debugging instead of this dialog box.

\ Exception Text ** System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary. at System.ThrowHelper.ThrowKeyNotFoundException() at System.Collections.Generic.Dictionary2.get_Item(TKey key) at MultiMiner.Xgminer.Api.Parsers.MinerStatisticsParser.ParseTextForMinerStatistics(String text, List1 minerStatistics) in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Xgminer.Api\Parsers\MinerStatisticsParser.cs:line 24 at MultiMiner.Xgminer.Api.ApiContext.GetMinerStatistics() in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Xgminer.Api\ApiContext.cs:line 82 at MultiMiner.Win.Forms.MinerForm.GetMinerStatisticsFromAddress(String ipAddress, Int32 port) in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Win\Forms\MinerForm.cs:line 5558 at MultiMiner.Win.Forms.MinerForm.GetCacheMinerStatisticsFromAddress(String ipAddress, Int32 port) in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Win\Forms\MinerForm.cs:line 5238 at MultiMiner.Win.Forms.MinerForm.<>cDisplayClass14f.b14b() in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Win\Forms\MinerForm.cs:line 5297

\ Loaded Assemblies ** mscorlib Assembly Version: 2.0.0.0 Win32 Version: 2.0.50727.5483 (Win7SP1GDR.050727-5400)

CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v2.0.50727/mscorlib.dll

nwoolls commented 10 years ago

Looks like you have an ASIC on your network that has a broken RPC API implementation - maybe the BTC Garden devices again?

This error means that the STATS RPC API call does not return a value for ID.

ManeBjorn commented 10 years ago

It could be I have two different BTC Gardens on the network. What should I do?

On Fri, Sep 19, 2014 at 5:52 PM, Nate Woolls notifications@github.com wrote:

Looks like you have an ASIC on your network that has a broken RPC API implementation - maybe the BTC Garden devices again?

This error means that the STATS RPC API call does not return a value for ID.

— Reply to this email directly or view it on GitHub https://github.com/nwoolls/MultiMiner/issues/164#issuecomment-56241012.

Scott Fargo

Head Of Mining News Dept. CryptoCoinsNews.com

nwoolls commented 10 years ago

Unplug them and then try opening MultiMiner - that is if you have the time. I'd love to know the offending device. It's just temporary.

In the long term revert to 3.4.7 and I'll get a fix out.

ManeBjorn commented 10 years ago

Hi Nate, It seems to go away after I take the BTC Gardens off the network. I wish BTC Garden would get their crap together. Scott

On Fri, Sep 19, 2014 at 6:03 PM, Nate Woolls notifications@github.com wrote:

Unplug them and then try opening MultiMiner - that is if you have the time. I'd love to know the offending device. It's just temporary.

In the long term revert to 3.4.7 and I'll get a fix out.

— Reply to this email directly or view it on GitHub https://github.com/nwoolls/MultiMiner/issues/164#issuecomment-56241966.

Scott Fargo

Head Of Mining News Dept. CryptoCoinsNews.com

phalanx2 commented 10 years ago

Looks like Im getting the same issue after updating. Im using it to exclusively monitor antminer S3's.

See the end of this message for details on invoking just-in-time (JIT) debugging instead of this dialog box.

\ Exception Text ** System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary. at System.ThrowHelper.ThrowKeyNotFoundException() at System.Collections.Generic.Dictionary2.get_Item(TKey key) at MultiMiner.Xgminer.Api.Parsers.MinerStatisticsParser.ParseTextForMinerStatistics(String text, List1 minerStatistics) in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Xgminer.Api\Parsers\MinerStatisticsParser.cs:line 24 at MultiMiner.Xgminer.Api.ApiContext.GetMinerStatistics() in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Xgminer.Api\ApiContext.cs:line 82 at MultiMiner.Win.Forms.MinerForm.GetMinerStatisticsFromAddress(String ipAddress, Int32 port) in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Win\Forms\MinerForm.cs:line 5558 at MultiMiner.Win.Forms.MinerForm.GetCacheMinerStatisticsFromAddress(String ipAddress, Int32 port) in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Win\Forms\MinerForm.cs:line 5238 at MultiMiner.Win.Forms.MinerForm.<>cDisplayClass14f.b14b() in d:\Data\Visual Studio Projects\Personal\MultiMiner\MultiMiner\MultiMiner.Win\Forms\MinerForm.cs:line 5297

nwoolls commented 10 years ago

Odd, I monitor S1s and S3s without any issues. Both have the proper STATS response (as well as R3-Box and several standalone CGMiner and BFGMiner instances).

Is this a newer firmware version?

ManeBjorn commented 10 years ago

HI Nate, I have the newest Firmware for my S3 as well as the S3+ and both will drop on and off the multiminer network list several times per day. They both work with out a hiccup though. Scott

On Fri, Sep 19, 2014 at 8:36 PM, Nate Woolls notifications@github.com wrote:

Odd, I monitor S1s and S3s without any issues. Both have the proper STATS response (as well as R3-Box and several standalone CGMiner and BFGMiner instances).

Is this a newer firmware version?

— Reply to this email directly or view it on GitHub https://github.com/nwoolls/MultiMiner/issues/164#issuecomment-56251486.

Scott Fargo

Head Of Mining News Dept. CryptoCoinsNews.com

nwoolls commented 10 years ago

Can you folks give this build a try please?

https://www.dropbox.com/s/sxfbw7elm8z40v9/MultiMiner-3.5.0.zip?dl=0

ManeBjorn commented 10 years ago

Hi Nate, I will test it now. Scott

On Fri, Sep 19, 2014 at 10:33 PM, Nate Woolls notifications@github.com wrote:

Can you folks give this build a try please?

https://www.dropbox.com/s/sxfbw7elm8z40v9/MultiMiner-3.5.0.zip?dl=0

— Reply to this email directly or view it on GitHub https://github.com/nwoolls/MultiMiner/issues/164#issuecomment-56254570.

Scott Fargo

Head Of Mining News Dept. CryptoCoinsNews.com

phalanx2 commented 10 years ago

I just tested it and its doesn't crash. Thanks. It didn't find all my miners. It only lists about 80% of them. This has been an issue in all your versions though so I think we can consider this issue fixed. It also displays the temperature which it has never done before.

As to your firmware question, all my S3's are running the latest firmware; when I received my shipment of S3+'s a week ago I went ahead and updated the firmware on all my units. They did work fine on multiminer 3.4.7.

phalanx2 commented 10 years ago

Just like ManeBjorn, some of mine will drop from the list throughout the day. This has happened on all multiminer versions that I've used. The actual S3's are running fine, just not listed.

nwoolls commented 10 years ago

@phalanx2 thanks for the feedback. I'll look to see if upping the timeouts when searching for Network Devices helps in a future update.

Fixed in 202174fccb5f681fc8d4d8328347a77d0dab3287

nwoolls commented 10 years ago

@phalanx2 if there's any chance you'd set me up with remote access to your MultiMiner PC (RDP, VNC, TV, whatever works) that would definitely help me diagnose / fix the issue with devices dropping off. If so please email me at nwoolls @ gmail

nwoolls commented 10 years ago

@phalanx2 and @ManeBjorn if you folks get time can you try https://www.dropbox.com/s/gpp6uma43uk6iru/MultiMiner-3.5.1.zip?dl=0

I have increased the timeout when checking on Network Devices from 500ms to 1500ms. I'd like to see if this helps with the devices that drop off / on in MultiMiner throughout the day.

Thanks in advance!

phalanx2 commented 10 years ago

I've just installed this version and on startup it detects 7 out of 8 miners. Ill let you know how it goes after running for several hours. I can give you teamviewer access to this small group of miners if you like. I've separated them from the rest in my farm just so that I test various monitoring software.

On Sun, Sep 21, 2014 at 12:33 PM, Nate Woolls notifications@github.com wrote:

@phalanx2 https://github.com/phalanx2 and @ManeBjorn https://github.com/ManeBjorn if you folks get time can you try https://www.dropbox.com/s/gpp6uma43uk6iru/MultiMiner-3.5.1.zip?dl=0

I have increased the timeout when checking on Network Devices from 500ms to 1500ms. I'd like to see if this helps with the devices that drop off / on in MultiMiner throughout the day.

Thanks in advance!

— Reply to this email directly or view it on GitHub https://github.com/nwoolls/MultiMiner/issues/164#issuecomment-56304177.

nwoolls commented 10 years ago

That would be awesome - you can email info to nwoolls @ gmail. If I have access to the PC with MultiMiner I can tweak the timeouts and get something that works consistently.