nwoolls / homebrew-xgminer

Homebrew formulas for CGMiner and BFGMiner
35 stars 27 forks source link

v4.10.0 with write_config fix #19

Open nkamitaki opened 7 years ago

nkamitaki commented 7 years ago

As noted, v4.9.1 has a linux-specific function that isn't implemented in Mac OSX, causing builds to fail:

https://github.com/nwoolls/homebrew-xgminer/issues/17 https://stackoverflow.com/questions/11680461/monotonic-clock-on-osx

this was fixed by v4.10.0 of cgminer:

https://github.com/ckolivas/cgminer/commit/a40cb506754171548681294a5a4f848bc6f0acc3

However, despite compiling correctly, v4.10.0 had a broken write_config function from a missing input setting variable required after expanding Gekko miner's frequency range:

https://bitcointalk.org/index.php?topic=28402.msg20526893#msg20526893

that was just patched by ckolivas in master/cgminer:

https://github.com/ckolivas/cgminer/commit/fc33786a4b8699c95db382ab6fd4969a527cd5dd

As far as I can tell, this seems to compile and mine correctly on my machine with write_config now working using all previously set configuration flags. Besides the general compilation fix for MacOSX, it seems worthwhile to bump it to the current release to enable support for recent miner additions.

Only other thing edited was introducing formal dependencies on jansson and ncurses to avoid brew linking conflicts with hombrew-core/jansson used by other formulas (ex. nghttp2, bfgminer).