search

nwplus / nwhacks2019

⛰ The official website, registration, and check-in system for nwHacks 2019
https://2019.nwhacks.io
Other
12 stars 3 forks source link

no-alert? #70

Open bobheadxi opened 6 years ago

bobheadxi commented 6 years ago

JavaScript’s alert, confirm, and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation... This rule is aimed at catching debugging code that should be removed and popup UI elements that should be replaced with less obtrusive, custom UIs.

https://eslint.org/docs/rules/no-alert

Relevant code: https://github.com/nwhacks/nwhacks2019/blob/7436578f3a2f1177463cbd0ef80323a15df597f1/web/components/application/hacker/Hacker.js#L53

Thoughts, @mingyokim ?

mingyokim commented 6 years ago

I’d say alerts are fine as long as design team is fine with it, since we don’t have the custom UI for alerts ready to use right now. Alerts would help us move forward faster to have an MVP without compromising functionality

bobheadxi commented 6 years ago

Yeah, I'm fine with it for now, just noticed our linter complaining.

Any thoughts on this @sherryyx / design team? (speaking of which would be nice if we could just tag @nwhacks/design 😛 )

Marking as low-priority for now

sherryyx commented 6 years ago

@bobheadxi Yeah let’s just leave it for now!