add charity options for HC2023

nwplus / portal

portal for hackers at nwplus hackathons

https://portal.nwplus.io/

12 stars 1 forks source link

add charity options for HC2023 #514

Closed alvinkam33 closed 1 year ago

alvinkam33 commented 1 year ago

couple of notes:

very basic implementation, used a required dropdown (not sure if we wanted this to be required field?) it saves in the database as the field 'charityChoice', lmk if there's any other action items
charities hard coded, not sure if there was a way in admin portal to set up charities in the DB. also made the value/label the same
if we want to add a way for people to view a description of each of the charities (e.g. a tooltip), i could do that

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit a5b972c):

https://nwplus-ubc--pr514-hackcamp2023-chariti-45bn4blk.web.app

_{(expires Tue, 14 Nov 2023 07:54:15 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48}

meleongg commented 1 year ago

Thank you for the quick PR!

Keeping it as required sgtm
hardcoding charities should be okay since I don't think HackCamp will be actively changing these options
tooltip feature could be nice -> I'll ping hackcamp for their input

How did you test these changes?

I used my person email and submitted a project - firebase projects collection correctly adds the field

alvinkam33 commented 1 year ago

yeah i just made a personal acc, applied and changed my status to acceptedAndAttending and check-in to true to access the project submission form, lmk if there are any concerns with that