cmd-f 2024 Hacker App changes

nwplus / portal

portal for hackers at nwplus hackathons

https://portal.nwplus.io/

12 stars 1 forks source link

cmd-f 2024 Hacker App changes #565

Closed meleongg closed 9 months ago

meleongg commented 9 months ago

Description

details in Notion here
POC: @meleongg

Other considerations

band-aid fix currently using nwHacks theme in ThemeProvider.js -> switch this to cmd-f when official portal reskin is ready and switch the logos to cmd-f
lots of tech debt/repeated code in Questionnaire.js, ReviewCards.js

github-actions[bot] commented 9 months ago

Visit the preview URL for this PR (updated for commit fbf60c9):

https://nwplus-ubc--pr565-cmd-f2024-hacker-app-ik2dm94d.web.app

_{(expires Sat, 17 Feb 2024 20:18:04 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48}

michelleykim commented 9 months ago

The questions look good to me, but just a nitpick- on mobile the checkmark for some questions doesnt show up and its hard to see what is selected and what is not. But this change can totally be made after we meege the changes for 7pm release Screenshot_20240209_174327_Samsung Internet

DonaldKLee commented 9 months ago

are we merging rn or right at 7?

michelleykim commented 9 months ago

are we merging rn or right at 7?

Doesn't matter. We definitely don't have to wait til 7, but we can take time