search

nwronski / batch-transcode-video

Batch transcode videos using the video_transcoding gem
MIT License
43 stars 8 forks source link

Disable crop detection in this script? #5

Closed JMoVS closed 5 years ago

JMoVS commented 6 years ago

Transcode-video by now allows to pass crop detection parameters as well as a fallback crop to transcode-video directly. Is batch-transcode-video calling transcode-video with the --detect-crop auto option? Or is it manually calling detect-crop and then passing those arguments to transcode-video?

nwronski commented 6 years ago

IIRC, the default behavior is to run detect-crop for each file and use the value provided from that command when calling transcode-video. You can also override that behavior by passing a --force option with the crop value you'd like to use and then all videos in the batch are cropped using that value.

More information about the options is available using the --help option.

JMoVS commented 6 years ago

As one is not actively examining the output of detect-crop manually, and as transcode-video has the option to pass "--crop detect" to get the behaviour of detect-crop, I think we should change this to rip out the logic for detect-crop parsing and instead use the built-in crop detection (which would also make it easier to supply crop values as you don't have to "force" it anymore and can specify for example which one should be the fallback crop in case of conflict.

Can you point me to the relevant code bits and also maybe where I could read up on how I get a working development environment for this script going? I'd try to rip that out and then submit a pull request.

nwronski commented 6 years ago

Sure, the crop detection happens here.

JMoVS commented 5 years ago

I'm sorry, I can't do this. It would be great if I could disable crop parameters that are passed from this script and instead use @donmelton's --crop detect and fallback_crop parameters then as additional parameters instead. Would that be a lot of work?

nwronski commented 5 years ago

try out the --nocrop option in v2.0.0 to disable batch-transcode-video's crop detection logic. you could also use --nocrop in combination with custom options for transcode-video:

batch-transcode-video --input source/ --output finished/ --nocrop -- --crop detect
JMoVS commented 5 years ago

that's exactly why I wanted this option. I now use --nocrop -- --crop detectwith the fallback crop set to minimal ;-)