nws321 / pe

0 stars 0 forks source link

Sort only allows sorting by name #4

Open nws321 opened 1 week ago

nws321 commented 1 week ago

It seems that your sort only allows by sorting both ascending and descending order of name, however, since you have the favourite parameter in place already, I think it would make more sense to allow sorting by favourites at the top rather than alphabetically.

Screenshot 2024-11-15 at 4.46.43 PM.png

soc-pe-bot commented 5 days ago

Team's Response

Hi tester, I understand that a user might want to sort by favourites, since that is a attribute of our contacts as well, but our team agreed that this is a feature that adds little value in our product. Here's why:

(A) We have implemented a comprehensive find command that searches for favourites effectively and efficiently.

Steps:

  1. find f/ Screenshot 2024-11-18 at 12.24.12 PM.png

Output: Screenshot 2024-11-18 at 12.25.50 PM.png

(B) The value in sorting by favourites, which is a binary classification, is minimal. If users would like to see all favourited contacts in one place, they could use the find command. Unlike sorting by name which allows a useful arrangement of contacts potentially used for comparing contact details with external documents, sorting by favourites has minimal similar use.

_

Then again, we appreciate your feedback and it might be useful when introduce more advanced features in the future. As of now, according to the course website,

"In general, a flaw (e.g., a missing feature, a suboptimal design of a feature, a known bug) can be considered NotInScope if rectifying it is less important than the work that has been done already (because it is fine to delay lower priority work until future iterations)"

we consider the feature outline by the tester to be of lower priority and hence is not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]