nwunderly / starlette-discord

"Login with Discord" support for Starlette and FastAPI
https://starlette-discord.rtfd.io
MIT License
32 stars 11 forks source link

Improvements to oauth.py #21

Open nwunderly opened 2 years ago

nwunderly commented 2 years ago

oauth.py is a bit of a mess at the moment. It's meant to be an internal class, and it's essentially just a port of a requests-based implementation that I pulled from a Gist a while ago. It's in desperate need of some love.

Any improvements to the file are welcome, and will be accepted as PRs. This issue will remain open until the file is fully improved.

Some ideas:

This is a bit of a more complicated task. It's likely something I'll revisit in the coming months, and (if necessary) just rewrite from scratch myself. That said, any improvements to library internals are always welcome.

Happy Hacktoberfest!! :smile:

akhilsharmaa commented 2 years ago

This seems interesting I would like to work on this issue.