Solution proposal for issue #8.

nwunderly / starlette-discord

"Login with Discord" support for Starlette and FastAPI

https://starlette-discord.rtfd.io

MIT License

32 stars 11 forks source link

Closed chrisdewa closed 3 years ago

chrisdewa commented 3 years ago

Modified DiscordOAuthClient method session to accept token parameter.

DiscordOAuthSession has the following changes:

the constructor now accepts a token parameter for pervously generated access tokens.
self._discord_token is now public (self.discord_token)
Removed __aenter__ overwrite and moved token fetching to method self._discord_request, this allows sessions to be created and used even without a context manager.

chrisdewa commented 3 years ago

Implemented suggested improvements by @nwunderly.

Im not entirely sure the methods session and session_from_token are adequately named though

nwunderly commented 3 years ago

Im not entirely sure the methods session and session_from_token are adequately named though

Yeah, I was thinking the same thing. It's all I can think of, though.

About to push some changes here, I think this is looking pretty good now.