nwutils / nw-builder

Build NW.js applications for Linux, MacOS and Windows
MIT License
1.68k stars 302 forks source link

EN_US is not defined #1125

Closed hohnworld closed 2 months ago

hohnworld commented 2 months ago

{ "name": "nw-demo", "version": "1.0.0", "description": "", "main": "index.js", "scripts": { "start": "nw src/", "build": "nwbuild --glob=false src" }, "keywords": [], "author": "", "license": "ISC", "devDependencies": { "nw": "0.85.0" } } C:\Users\Administrator\Desktop\demo\nw-demo>npm run build

nw-demo@1.0.0 build nwbuild --glob=false src

ReferenceError: EN_US is not defined at setWinConfig (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/bld.js:335:45) at async bld (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/bld.js:185:5) at async nwbuild (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/index.js:116:7) node:internal/process/promises:289 nw-demo.zip

        triggerUncaughtException(err, true /* fromPromise */);
        ^

ReferenceError: EN_US is not defined at setWinConfig (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/bld.js:335:45) at async bld (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/bld.js:185:5) at async nwbuild (file:///C:/Users/Administrator/AppData/Roaming/npm/node_modules/nw-builder/src/index.js:116:7)

Node.js v20.14.0

nw-demo.zip

ayushmanchhabra commented 2 months ago

Fix will be to move this line https://github.com/nwutils/nw-builder/blob/7aa6f08927869c8ceb5da686bb53e48f537f7a40/src/bld.js#L329

above this line https://github.com/nwutils/nw-builder/blob/7aa6f08927869c8ceb5da686bb53e48f537f7a40/src/bld.js#L320

ayushmanchhabra commented 2 months ago

Afk so can't do it myself right now, open to PR