nwutils / nw-builder

Build NW.js applications for Linux, MacOS and Windows
MIT License
1.68k stars 302 forks source link

Wrong Permissions... #276

Closed ghost closed 8 years ago

ghost commented 8 years ago

Someone over at the PopcornTime CE mentioned that nw-builder might be this issue for wrong permissions;

https://github.com/PopcornTimeCE/desktop/issues/22

When I compile PopcornTime CE in Linux I'm seeing these that I mentioned in the issue as executable.

Is this a problem with nw-builder causing this?

thank you

adam-lynch commented 8 years ago

That could easily be true. I know there's some chmodding done in nw-builder. Would you mind having a look at the code and maybe make a PR? :smile:

ghost commented 8 years ago

I'm not a coder, and I'm clueless with this sort of code, c stuff maybe I could handle.

adam-lynch commented 8 years ago

No problem. So could you tell me exactly what you'd expect the permissions to be?

ghost commented 8 years ago

I would of thought they would be 644 since they are files, and not apps or scripts that call to be executable/run...

Because in the original version of Popcorn Time when I compiled it they were 644, but for some reason when building this new Community Edition they are turning out executable.

And I thought both versions of Popcorn Time were using nw-builder, so I'm not sure why the difference in permissions, unless the original didn't use nw-builder, and this is something new being used for the Community Edition.

adam-lynch commented 8 years ago

The Popcorn Time issue link is 404ing :/

adam-lynch commented 8 years ago

http://webcache.googleusercontent.com/search?q=cache:https://github.com/PopcornTimeCE/desktop/issues/22 :smile:

ghost commented 8 years ago

Seems as though the MPAA has everyone on the run, so everytime you turn around a repo is up a repo is down, or someone else is taking over or backing up the project...

https://github.com/PopcornTime-CE/desktop/issues/1#issuecomment-165861107

thanks

adam-lynch commented 8 years ago

Closing as a duplicate of #289. Correct me if I'm wrong.