Open EelcoLos opened 2 weeks ago
FYI for ppl following this: I tried debugging this myself. It seems harder to work on this as a beginner on this repo than I thought. My thoughts so far:
CONTRIBUTING.md
starting guide isn't complete.
Validating plug-in changes locally
The recommended way to validate your changes is to deploy the plugin locally to a fresh nx workspace.
* A sandbox workspace can be generated via `yarn sandbox` * This script will build/publish the plugin to a sandbox workspace (./tmp/sandbox) * Verdaccio is leveraged to start a locally running instance of npm (http://localhost:4872/) The server will close when the script is stopped * use `nx generate @nx-dotnet/core:[generator]` to validate your changes manually
yarn sandbox
references files that do not exist: https://github.com/EelcoLos/nx-dotnet/blob/6dc1e995be359f372da506c65e1e20ccd6682ca3/tools/scripts/sandbox.ts#L11C1-L12C1
and publish-all
https://github.com/EelcoLos/nx-dotnet/blob/6dc1e995be359f372da506c65e1e20ccd6682ca3/tools/scripts/sandbox.ts#L24C6-L24C7
, which was removed in https://github.com/nx-dotnet/nx-dotnet/pull/874 (file itself: https://github.com/nx-dotnet/nx-dotnet/blob/5f0dd3a49717e12a7fe788c729c4a35c4bb7adc9/tools/scripts/publish-all/index.ts)
NXPluginV1
, whereas v20 demands NXPluginV2
on various files. This migration will have some work in here, but is doable i guess.create-nx-workspace
with preset empty
. This preset doesn't exist any more. Also, when trying to execute this, I get a Failed to create nx workspace
error, without being able to dive deeper.Hope this'll at least inform you. My question is: should I log these as seperate issues? And if so, as it's needed for this package to move forward, still be part of the same work?
As pointed out by @AgentEnder on https://github.com/nx-dotnet/nx-dotnet/discussions/851#discussioncomment-10003811 , he's working on a total redesign of the plugin. Hopefully it'll be here soon.
Current Behavior
Migrating to NX v20, then running
npm i
after installation is breaking theExpected Behavior
@nx-dotnet/core
runs with nx v20Github Repo
https://github.com/EelcoLos/nx-tinkering/tree/error/nx-dotnet-v20-migration
Steps to Reproduce
npx nx migrate latest
npm i
npx nx migrate --run-migrations
npm i
Nx Report
nx.json
Failure Logs
Additional Information
No response