Allow using objects as key (in Maps, Sets, ...)

nx-js / observer-util

Transparent reactivity with 100% language coverage. Made with ❤️ and ES6 Proxies.

MIT License

1.2k stars 94 forks source link

Allow using objects as key (in Maps, Sets, ...) #26

Closed BenoitZugmeyer closed 6 years ago

BenoitZugmeyer commented 6 years ago

Currently, keys are always used as string, since they are stored as property name of an object. This PR allows using objects as key by using a Map instead of an object for the storage.

I hope it makes sense. Great project!

solkimicreb commented 6 years ago

Awesome! 🙂 That's a pretty nasty bug, thanks for catching and fixing it. I am checking the performance impact and merging this soon. (I don't think this will slow things down.)

BenoitZugmeyer commented 6 years ago

I updated the PR!

solkimicreb commented 6 years ago

Perfect, thanks! The next patch release is rolling out later today with your fix 🙂

solkimicreb commented 6 years ago

Published it as v4.1.3, the change log is here: https://github.com/nx-js/observer-util/releases/tag/v4.1.3. Thanks again 👍