search

nx10 / httpgd

Asynchronous http server graphics device for R.
https://nx10.github.io/httpgd
GNU General Public License v2.0
365 stars 19 forks source link

CRAN packages showing warnings with GCC 14 #186

Closed nx10 closed 1 month ago

nx10 commented 2 months ago

I received the following notice from CRAN on 2024-05-06:

GCC 14 is due to be released tomorrow (in some time zone) and we have been testing CRAN against 14.1RC (which reports as 14.0.1). Packages

   Numero SheetReader batchmix epanet2toolkit httpgd

have new compilation warnings shown in the fedora-gcc results on CRAN.

Please correct before 2024-06-06 to safely retain your package on CRAN.

I think it's referring to this:

checking whether package ‘httpgd’ can be installed ... [103s/166s] WARNING
Found the following significant warnings:
  lib/crow/http_parser_merged.h:1925:9: warning: '((crow::http_parser*)((char*)<unknown> + 24))[105].crow::http_parser::data' is used uninitialized [-Wuninitialized]
See the install log for details.
used C++ compiler: ‘g++-14 (GCC) 14.1.0’

https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-gcc/httpgd-00check.html

Which points to this section of the crow library:

https://github.com/nx10/httpgd/blob/2174dcd7c419ddf80a171fd0107a768bc710b7e8/src/lib/crow/http_parser_merged.h#L1922-L1930

Looks safe to me, ~but maybe we can just switch line 1925 and 1926 to appease GCC.~

nx10 commented 1 month ago

This definitely was a false positive but I was able to get rid of the warning by just commenting out this section of code in the CrowCpp library as its not used.

Submitting httpgd 2.0.2 now (no need for anyone to update this is purely to appease CRAN...).