nxengine / nxengine-evo

nxengine refactoring
https://discord.gg/jnwmA7DhQh
GNU General Public License v3.0
488 stars 82 forks source link

Weapons inconsistencies #141

Open Subc2 opened 5 years ago

Subc2 commented 5 years ago

There are some weapons-related differences between NXEngine-evo and Cave Story:

isage commented 5 years ago

The fourth blast door is too easily pushed by Blade lvl 3.

There seems to be two separate bugs: 1) bounding box for invisible object is too big 2) blade lv3 doesn't work as intended, and i can't seem to figure out what i'm doing wrong, ugh

xordspar0 commented 3 years ago

When you charge Spur, press Q and change weapon, Spur should remain charged.

Ha, I did not know about that. That is probably unintentional and kind of annoying to recreate in NXEngine because the charge normally resets when you switch weapons with A and S.

1 exp crystal doesn't level up Nemesis from level 1 to level 2.

Good catch. This is actually true for all weapons. They all take 1 extra experience to level up from level 1 to 2. Additionally, after leveling up, the meter in the HUD has 1 XP already. In the original game it reset to 0. This is an easy off-by-one fix.

xordspar0 commented 3 years ago

@Subc2, I just tried your latest change on master, https://github.com/nxengine/nxengine-evo/commit/dde92460f35d3e0221cb2d4073231a043d220092. Thanks for improving this. I was surprised to find that the new behavior is almost identical to the original. I found one more inconsistency, however. This is where the original Cave Story behavior gets really annoying to recreate exactly.

  1. If you switch weapons using the menu and then switch back without holding the fire button, the spur should fire immediately. Cave Story - spur fire on release

  2. If you switch weapons using the menu, then switch weapons with the normal buttons, then switch back to the spur while holding fire button, it should keep the charge. You fixed this in your change. Thanks. Cave Story - spur hold charge

  3. However, if you switch weapons using the menu, then switch weapons with the normal buttons, then switch back to the spur without holding the fire button, the spur should reset. This worked before your change. Cave Story - spur inconsistency

Subc2 commented 3 years ago

@xordspar0, thanks for pointing that out. I believe my recent changes fixed this issue. Let me know if there's another mechanic I didn't know of.