nxext / nx-extensions-ionic

Nx Extension for Ionic
MIT License
29 stars 8 forks source link

Update nx-extensions-ionic for the current NX version? #25

Open SvenBudak opened 5 months ago

SvenBudak commented 5 months ago

I created a new project with:

npx create-nx-workspace@latest
npm install -D @nx/angular --legacy-peer-deps
npm install --save-dev -D --exact @nxext/ionic-angular --legacy-peer-deps
npm install --save-dev -D --exact @nxext/capacitor --legacy-peer-deps

This resulted in the following package.json:

{
  "name": "@anime-sector/source",
  "version": "0.0.0",
  "license": "MIT",
  "scripts": {},
  "private": true,
  "devDependencies": {
    "@nx/angular": "^18.0.2",
    "@nx/js": "18.0.2",
    "@nx/workspace": "18.0.2",
    "@nxext/capacitor": "^17.0.1",
    "@nxext/ionic-angular": "^17.0.1",
    "nx": "18.0.2"
  }
}

After I realized that creating a new Ionic app is simply not possible, I took a closer look at the package.json and noticed that the following packages do not match the NX version numbers:

"@nxext/capacitor": "^17.0.1",
"@nxext/ionic-angular": "^17.0.1",

Could it be that nothing is working because the nxext packages have not yet been updated?

Is an update planned?

MatthijsReyers commented 5 months ago

Nx 18 was released two days ago, the ionic integrations are always a little bit behind nx unfortunately so it may be a while until they come out. If you don't absolutely require Nx 18 I would recommend using npx create-nx-workspace@17.3.2 for now, that's what I did.

SvenBudak commented 5 months ago

Oh, I should have checked when the latest NX update was released. I apologize, I was not aware that it was only two days ago. I was merely under the impression that the maintenance of this package might have been halted, as there are several topics in the issues section mentioning problems with the generate:application script, some of which are many months old. Therefore, I thought it made sense to inquire. Thank you for the information! In that case, I will wait for the update before considering reverting to an older NX version. :)

ZaLiTHkA commented 3 months ago

I see the packages in this project have now had their Nx dependencies and their own versions bumped to 18.x, so there does appear to have been some work towards this.. with that said, the Nx 18 release notes do actually state that...

Though this is a major version, there are no removals of previous deprecations. Any deprecations which were previously scheduled for Nx 18 are now scheduled for Nx 19 which will still be coming out around April 2024.

...so there wouldn't (shouldn't?) be any actual "breaking changes" to have to deal with here.


@MatthijsReyers just out of curiosity, if the 18.x range of these packages aren't quite "production ready" yet, what about maybe releasing them under a next or beta tag then?

an alternative (though probably less desirable) option would be to commit the dist folders to Git, allowing these packages to be installed directly from GitHub using something like https://gitpkg.vercel.app/.