nxext / nx-extensions

Nx Extensions for Stencil, Svelte, SolidJS, Preact, Ionic, and Capacitor
MIT License
458 stars 101 forks source link

Stencil: add support for Nx 19 #1089

Closed dgonzalezr closed 4 months ago

dgonzalezr commented 4 months ago

Is your feature request related to a problem? Please describe. Currently, we're not able to upgrade to Nx 19 due to an unresolved dependency tree.

CleanShot 2024-05-17 at 11 00 39@2x

To be able to update to the latest Nx version, I'm forced to override @nxext/stencil dependency tree as follows:

"@nxext/stencil": {
  "@nx/eslint": "$@nx/eslint",
  "@nx/jest": "$@nx/jest",
  "@nx/react": "$@nx/react",
  "@nx/storybook": "$@nx/storybook",
  "@stencil/core": "$@stencil/core"
}

Describe the solution you'd like

I would like to be able to update to the latest Nx without the need to override the dependency tree.

Describe alternatives you've considered

Peer dependencies related to Nx in packages/stencil/package.json should allow Nx 19 as well:

"peerDependencies": {
  "@nxext/svelte": "^18.0.0",
  "@nx/cypress": "^18.0.8",
  "@nx/storybook": "^18.0.8",
  "@nx/jest": "^18.0.8",
  "@nx/react": "^18.0.8",
  "@nx/eslint": "^18.0.8"
},

Additional context Add any other context or screenshots about the feature request here.

dgonzalezr commented 4 months ago

Closing this, I've tested the latest version and everything works as expected.