search

nxext / nx-extensions

Nx Extensions for Stencil, Svelte, SolidJS, Preact, Ionic, and Capacitor
MIT License
467 stars 102 forks source link

[Question] Stencil: pinned `@stencil/core` dependency #1143

Closed dgonzalezr closed 1 month ago

dgonzalezr commented 1 month ago

Describe the bug

Hi, I wanted to check if there’s a particular reason why the @stencil/core dependency has a fixed version.

CleanShot 2024-10-15 at 12 45 41

My @nx workspace is using the latest @stencil/core for our stencil components library, but @nxext/stencil v.20.0.1 now installs another version in the node_modules, meaning that our workspace has two versions.

CleanShot 2024-10-15 at 12 51 19

Our packages are using the right version, but I don't believe that fixing @stencil/core to a specific version is the best approach. I might be overlooking something.

To Reproduce Steps to reproduce the behavior:

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here.

DominikPieper commented 1 month ago

Ah, that's the damn eslint rule ^^' if you fix the version through eslint it takes the current version without a range ^^'

pawel-twardziak commented 1 month ago

@DominikPieper @dgonzalezr yeah, damn, will fix it in the upcoming PR. Thanks for your vigilance @dgonzalezr 👍