nxp-imx / imx-kobs

Tool to create and write Freescale/NXP I.MX NAND boot related boot data structure to nand flash
GNU General Public License v2.0
29 stars 26 forks source link

supported geometry check broken? #31

Open rhubert opened 3 years ago

rhubert commented 3 years ago

Hi, I've some trouble with a 2K+128B OOB Flash on a i.MX8. While debugging the code I found this check:

        /* verify it's a supported geometry */
        if (plat_config_data->m_u32Arm_type != MX7 &&
            plat_config_data->m_u32Arm_type != MX8Q &&
            plat_config_data->m_u32Arm_type != MX8MQ &&
            plat_config_data->m_u32Arm_type != MX8MN &&
            plat_config_data->m_u32Arm_type != MX8MP &&
            plat_config_data->m_u32Arm_type != MX6Q &&
            plat_config_data->m_u32Arm_type != MX6DL &&
            plat_config_data->m_u32Arm_type != MX6 &&
            plat_config_data->m_u32Arm_type != MX50 &&
            miu->writesize + miu->oobsize != 2048 + 64 &&
            miu->writesize + miu->oobsize != 4096 + 128 &&
            miu->writesize + miu->oobsize != 4096 + 224 &&
            miu->writesize + miu->oobsize != 4096 + 218 &&
            miu->writesize + miu->oobsize != 8192 + 376 &&
            miu->writesize + miu->oobsize != 8192 + 512) {
            fprintf(stderr, "mtd: device %s; unsupported geometry (%d/%d)\n",
                    mp->name, miu->writesize, miu->oobsize);
            goto out;
        }

https://github.com/NXPmicro/imx-kobs/blob/master/src/mtd.c#L987

For me this looks broken - it accepts every geometry as long as the soc is supported?