device: Delete references to CMSIS pack from the cmake files

nxp-mcuxpresso / mcux-sdk

MCUXpresso SDK

BSD 3-Clause "New" or "Revised" License

323 stars 142 forks source link

device: Delete references to CMSIS pack from the cmake files #126

Open mmahadevan108 opened 1 year ago

mmahadevan108 commented 1 year ago

CMSIS is no longer part of the SDK Git repo

mcuxsusan commented 1 year ago

Hi @mmahadevan108, directly remove the cmsis dependency in device_CMSIS.make could result build failure for projects include this device_CMSIS.cmake to get the NXP cmsis files, will see how to resolve the issue.

mmahadevan108 commented 1 year ago

Should we delete device_CMSIS.cmake since we do not include CMSIS in the SDK github and move this cmake to the CMSIS github repo we fork?

mcuxsusan commented 1 year ago

Hi @mmahadevan108, instead of deleting the device_CMSIS.cmake, I am thinking that maybe I could change the include(CMSIS_Include_core_cm) to include(CMSIS_Include_core_cm OPTIONAL) so that NO issue will be popped out if users like zephyr are not using our cmsis module, what do you see?