search

nxp-mcuxpresso / mcux-sdk

MCUXpresso SDK
BSD 3-Clause "New" or "Revised" License
301 stars 136 forks source link

Add support for newly introduced CCM Rev3 on i.MX93 #133

Closed LaurentiuM1234 closed 9 months ago

LaurentiuM1234 commented 10 months ago

Replica of https://github.com/zephyrproject-rtos/hal_nxp/pull/247. Tested locally with Zephyr on i.MX93.

LaurentiuM1234 commented 10 months ago

@mcuxsusan @zejiang0jason @nxp-wayne pls review

mcuxsusan commented 10 months ago

@JiafeiPan, please help review the feature file change.

dbaluta commented 10 months ago

@LaurentiuM1234 I agree with @JiafeiPan that we should introduce a config option in Zephyr to control the behavior of FSL_SDK_DISABLE_DRIVER_CLOCK_CONTROL bit.

Then we can address the 1:1 mapping in a later PR. Let's try to sort this out one patch at a time :)

Great work so far!

LaurentiuM1234 commented 10 months ago

@LaurentiuM1234 I agree with @JiafeiPan that we should introduce a config option in Zephyr to control the behavior of FSL_SDK_DISABLE_DRIVER_CLOCK_CONTROL bit.

Then we can address the 1:1 mapping in a later PR. Let's try to sort this out one patch at a time :)

Great work so far!

Done in https://github.com/zephyrproject-rtos/hal_nxp/pull/247.

LaurentiuM1234 commented 10 months ago

Changed approach to a ccm_base-oriented one. @JiafeiPan @mcuxsusan @zejiang0jason can you please review again? Thanks!

JiafeiPan commented 10 months ago

Changed approach to a ccm_base-oriented one. @JiafeiPan @mcuxsusan @zejiang0jason can you please review again? Thanks!

Update copyright to 2023?

LaurentiuM1234 commented 10 months ago

Changed approach to a ccm_base-oriented one. @JiafeiPan @mcuxsusan @zejiang0jason can you please review again? Thanks!

Update copyright to 2023?

Done.

JiafeiPan commented 10 months ago

Changed approach to a ccm_base-oriented one. @JiafeiPan @mcuxsusan @zejiang0jason can you please review again? Thanks!

Update copyright to 2023?

Done.

Looks fine for me except it seems need to merge two commit together (don't use a separate commit to update CR). thanks.

dbaluta commented 9 months ago

@mcuxsusan this is ready for merge!

mcuxsusan commented 9 months ago

Hi @dbaluta, will try to merge the patch tomorrow. Waiting for the feedback from the SDK driver owner, should have feedback tomorrow.

mcuxsusan commented 9 months ago

SDK driver owner is OK with the change.