search

nxp-mcuxpresso / mcux-sdk

MCUXpresso SDK
BSD 3-Clause "New" or "Revised" License
301 stars 136 forks source link

Add necessary changes for supporting the Zephyr DAI SAI driver on i.MX93 #148

Closed LaurentiuM1234 closed 6 months ago

LaurentiuM1234 commented 7 months ago

Tested locally using SOF with Zephyr on i.MX93.

mmahadevan108 commented 7 months ago

@mcuxsusan , can you please help assign reviewers to this PR.

mcuxsusan commented 7 months ago

@mmahadevan108, I have worked internally assigning the issue to our developer, no progress yet. cc @zejiang0jason to help check.

LaurentiuM1234 commented 6 months ago

@mcuxted Thanks for the suggestions! I've updated the PR accordingly. Could you please check again?

As for the TX/RX FIFO watermark issue: I've introduced MCUX_SDK_SAI_ALLOW_NULL_FIFO_WATERMARK which will maintain the old behavior if set to 0 (which is the default value).

LaurentiuM1234 commented 6 months ago

@zejiang0jason I've updated the PR according to your suggestion. Also tested it locally and works fine. Please have another look. Thanks!

zejiang0jason commented 6 months ago

thanks. @LaurentiuM1234 , I have no other comment, let's wait for @mcuxted .

mcuxted commented 6 months ago

thanks. @LaurentiuM1234 , I have no other comment too,

LaurentiuM1234 commented 6 months ago

Great! @mcuxsusan I believe this is ready for merge