nxp-mcuxpresso / mcux-sdk

MCUXpresso SDK
BSD 3-Clause "New" or "Revised" License
301 stars 136 forks source link

const-qualify buffer in UART_RTOS_Send #154

Closed escherstair closed 4 months ago

escherstair commented 6 months ago

This PR const-qualifies several variables in FSL API. See issues #59 and #117

DavidJurajdaNXP commented 4 months ago

Hi @escherstair , thank you for contribution. At this point we are no longer planning to extend the FreeRTOS API by new functionality. Drivers are currently in maintenance mode only, where we concentrate only on correction of critical issues.

escherstair commented 4 months ago

Hi @DavidJurajdaNXP I'm not sure I understand your point. This is not an extension by a new functionality. It's a fix of an unnecessary warning in case an user passes a const pointer to the functions. It has no drawbacks at all because:

If the user needs to certify the cource code, a third party consultant performs some static check on the code, and this kind of unnecessary warnings should be justified. Extra work that can be easily saved.

I ask you to reconsider this PR.