nxp-mcuxpresso / mcux-sdk

MCUXpresso SDK
BSD 3-Clause "New" or "Revised" License
339 stars 148 forks source link

[BUG] IOMUX macros are renamed in iMXRT1051 but not iMXRT1062 #217

Open liampribis opened 2 weeks ago

liampribis commented 2 weeks ago

Describe the bug Starting in SDK version 2.11.0, many of the IOMUXC macro definitions have been renamed on the iMX RT1051 and iMX RT1052 but not the iMX RT106x family. The renames all follow patterns like the following, ie trivial shuffling of the device and channel number.

- #define IOMUXC_GPIO_EMC_08_FLEXPWM2_PWMA01 0x401F8034U, 0x1U, 0x401F847CU, 0x0U, 0x401F8224U
+ #define IOMUXC_GPIO_EMC_08_FLEXPWM2_PWM1_A 0x401F8034U, 0x1U, 0x401F847CU, 0x0U, 0x401F8224U

I am not sure of the reasoning behind this rename. RT105x and RT106x have identical IOMUXC setups for 99% of pins. We have shared libraries that are used in both RT105x and RT106x. After updating past the rename, we now need to maintain a macro table to switch out the IOMUXC definitions based on target type, somewhat defeating the purpose of iomuxc.h.

To Reproduce

Expected behavior Diff should be similar as the chips are very similar. Identical pin muxes (most of them) should have identical macro names.

Maybe apply the same renaming scheme used for the RT105x to the RT106x, or revert the renaming that was done to the 105x.

Additional context This was not an issue (ie macro names were identical) until SDK 2.11.