nxp-mcuxpresso / mcux-sdk

MCUXpresso SDK
BSD 3-Clause "New" or "Revised" License
301 stars 136 forks source link

Add device_system.cmake file for MIMXRT685 and MIMXRT595 #55

Closed mmahadevan108 closed 2 years ago

mmahadevan108 commented 2 years ago

Prerequisites

Describe the pull request On the MIMXRT685, spilt this out of device_startup.cmake to be consistent with other platforms. Add device_system.cmake file for MIMXRT595

Fixes # (issue)

Type of change (please delete options that are not relevant):

Tests

mmahadevan108 commented 2 years ago

@mcuxsusan @dleach02 . We would like to start adding system_xxxx.c files in Zephyr. Hence this fix is needed so this file can be pulled in.

mcuxsusan commented 2 years ago

Hi @mmahadevan108, thanks for your contribution!

This misalignment of cmake component for RT595S and RT685S is because of the component data organization is different from others. I agree with your change to add a new device_system component because up layer stack needs system sources for device enablement, but currently I would suggest we do not modify the existing device_startup component in this PR because now only device_startup component is included for examples on RT685S and RT595S, so merging this PR may introduce build failure for our existing examples.

So, please update PR to only add the device_system cmake component, I will do update later on updating device_startup component and the include components for examples in our RT685S and RT595S.

mmahadevan108 commented 2 years ago

@mcuxsusan , thank you for your review. I have update this PR.