search

nxp-mcuxpresso / mcux-sdk

MCUXpresso SDK
BSD 3-Clause "New" or "Revised" License
323 stars 142 forks source link

Any specific reason why rtos lpuart send function data buffer variable is not const? #59

Closed Hadatko closed 7 months ago

Hadatko commented 2 years ago

https://github.com/NXPmicro/mcux-sdk/blob/81a42c9e5875b70f0acdf10c23aa977ce1135100/drivers/lpuart/fsl_lpuart_freertos.h#L132

In Send function the data shouldn't be changed and it looks like they are not. Isn't better to use const variable type? (i have data type conflict because it is not using const keyword)

Hadatko commented 1 year ago

?

DRNadler commented 1 year ago

NXP, Anybody there? I also have lots of problems with FSL API function arguments that should be const. Its a big application problem when sending lots of const configuration strings from flash, etc. Thanks!

mcuxsusan commented 1 year ago

Hi @DRNadler, appreciate if you could raise a new issue and provide more details for your case? I would like to reserve this issue specially to follow up the RTOS API parameter issue, I am wondering if you would like to provide feedback on common driver API parameter issue.

mcuxsusan commented 1 year ago

Sorry for the delayed reply. @DavidJurajdaNXP, could you please help check?

escherstair commented 9 months ago

Hi @mcuxsusan , @DavidJurajdaNXP I add my vote to this request. Anmd I point your attention to fsl_uart_freertos.h too https://github.com/nxp-mcuxpresso/mcux-sdk/blob/43a5a8df5728436f88dd1044fba66972bae723b6/drivers/uart/fsl_uart_freertos.h#L126

This issue is 2 years old....

escherstair commented 7 months ago

@mcuxsusan , @DavidJurajdaNXP sorry for pushing, but do you have news on this issue? Does my PR sound good to you?

DavidJurajdaNXP commented 7 months ago

Hi all, there is not any specific reason for missing const modifier, it is design choice of original author. At this point we are no longer planning to extend the FreeRTOS API by new functionality. Drivers are currently in maintenance mode only, where we concentrate only on correction of critical issues.